Refactor on enter submit in share form component

Description

Current behavior

  • The share form is being saved when pressing Enter, Ctrl + Enter, or clicking the Save button.

Expected behavior

  • The share form should be saved when pressing Ctrl + Enter, or clicking the Save button.
  • The share form should not be saved when only pressing Enter.

Linked issues

is duplicated by
Issue Type Icon ESFC-456 Custom default share names cannot be changed in Space configuration on default tab Priority: Medium
Released
relates to
Issue Type Icon ESFJ-829 Refactor on enter submit in share form component Priority: Medium
Withdrawn

Activity

Automation for Jira 8 January 2024, 12:01

Hello @Jakub Myśliński,

Please merge code to dev branch.
This is the best moment to add more information that can be helpful to prepare release notes.

  • Can you prepare short overview of change that can be used in release notes?

  • Please provide short GIF that showcase feature.

  • If GIF make no sense, can you provide image that highlights feature that can be used in release notes (cropped & annotated)?

Sagar Rawat 8 January 2024, 12:01

@Jakub Myśliński Fix verified - QA environment.

Kamil Zarychta 29 December 2023, 08:43

@Jakub Myśliński approved

Automation for Jira 28 December 2023, 23:34

Hello @Kamil Zarychta,
Task is ready for review.

@Igor Hercer please make sure reviewer
have easy access to contend to be reviewed.

If this is code change. Please make sure PR is created.
If this is new documentation, blogpost, etc. Please provide link to page.

Sagar Rawat 9 November 2023, 13:02

@Igor Hercer Fix failed - QA environment. The shares are not saved on clicking enter button as other tabs are selected or any option is selected on External share tab.

Automation for Jira 3 November 2023, 09:59

Hello @Igor Hercer ]

This is the best moment to add more information that can be helpful for tester.

  • What areas are affected?

  • What are potential edge cases?

  • Was it checked for XSS problems?

  • Does change affect security, is new data exposed?

Please attach - Before / After screenshot if possible.

Igor Hercer 3 November 2023, 09:59

@Parsa Shiva @Sagar Rawat Deployed on QA.:) Please test on enter submit feature while creating share:)

Automation for Jira 20 September 2023, 13:39

Hello @Michał,
Task is ready for review.

@Igor Hercer please make sure reviewer
have easy access to contend to be reviewed.

If this is code change. Please make sure PR is created.
If this is new documentation, blogpost, etc. Please provide link to page.

Automation for Jira 20 September 2023, 13:39

Hello @Krzysztof Bogdan

This is the best moment to add more description, wire-frames, comments.
Why we doing this?
What is expected result?