Reverse the color palete for dark theme
Description
We need to reverse the color palette for dark theme.
In Jira color palette in light theme looks like:
and in dark theme:
Both checked buttons are signed as “dark green”. Atlassian reverse the color palette automatically when you switch a theme. So If you set a dark font on light background after switching to dark theme you’ll have a proper light font.
We need the same mechanism for External page.
This also causes a bug when editing the External share page
ESFJ-378: Edit toolbar - dark themeReleased
Also there was a mismatch in page theme editor theme when:
in global settings dark mode was disabled
users browser is set to darkmode
For testing:
Editor theme and inserted elements should behave similarly to editor in Jira,
for example:
dark text in light mode should turn light in dark mode (high contrast and visible)
Easiest way will be to compare editor behaviour/comments look between Jira and ESFJ.
Please check from both perspectives (both for light and dark mode):
check how comments posted from ESFJ look in Jira
check how comments posted from Jira look in ESFJ
Activity
Details
Priority
Medium
Hello @Miłosz Jaskólski,
Please merge code to dev branch.
This is the best moment to add more information that can be helpful to prepare release notes.
Can you prepare short overview of change that can be used in release notes?
Please provide short GIF that showcase feature.
If GIF make no sense, can you provide image that highlights feature that can be used in release notes (cropped & annotated)?
Improvement implemented - QA env
Strikethrough, underline is not the same color as selected text Fix failed
When you copy/ paste formatted text in ES, it formats text to the last color Fix failed
@Miłosz Jaskólski
When you copy/ paste formatted text in ES, it formats text to the last color
Strikethrough, underline is not the same color as selected text
Jira:
ES:
black color is barely visible in ES
Jira (internal comment):
ES:
Hello @Miłosz Jaskólski
This is the best moment to add more information that can be helpful for tester.
What areas are affected?
What are potential edge cases?
Was it checked for XSS problems?
Does change affect security, is new data exposed?
Please attach - Before / After screenshot if possible.
@Mariusz Szymański hi it's me again, slight changes c:
junit was spitting out error so I fixed the cause
@Mariusz Szymański I talked with Piotrek about how this thing works, so the idea and execution has changed a bit (a lot)
Hello @Mariusz Szymański,
Task is ready for review.
@Miłosz Jaskólski please make sure reviewer
have easy access to contend to be reviewed.
If this is code change. Please make sure PR is created.
If this is new documentation, blogpost, etc. Please provide link to page.
Hello @Krzysztof Bogdan
This is the best moment to add more description, wire-frames, comments.
Why we doing this?
What is expected result?