The link option in the editor is not dark mode friendly and includes "Link target" which is an unnecessary tab

Description

There is an additional tab which may be confusing and unnecessary for users, in addition the whole option is not dark mode friendly.


Pre-conditions

Have dark mode enabled

Steps to reproduce

  1. Navigate to share creation (via board share)
  2. Click on the “Create” button
  3. On the description field convert a text to link using the “Link“ option
  4. Notice the tab opens a light mode pop-up
  5. Observe the additional tab call “Link target“

Linked issues

relates to
Issue Type Icon ESFJ-171 [EXTERNAL USER][ISSUE] - Allow External Share user to create issue Priority: Low
Released

Activity

Automation for Jira 31 August 2023, 14:13

Hello @Miłosz Jaskólski,

Please merge code to dev branch.
This is the best moment to add more information that can be helpful to prepare release notes.

  • Can you prepare short overview of change that can be used in release notes?

  • Please provide short GIF that showcase feature.

  • If GIF make no sense, can you provide image that highlights feature that can be used in release notes (cropped & annotated)?

Sagar Rawat 31 August 2023, 14:13

@Miłosz Jaskólski Fix verified - QA environment.

Sagar Rawat 31 August 2023, 09:58

@Miłosz Jaskólski Fix failed - QA environment. Link type and Protocol drop down options appears too bright.

Miłosz Jaskólski 30 August 2023, 15:43

@Sagar Rawat should work on shared board as well

Sagar Rawat 30 August 2023, 13:42

@Miłosz Jaskólski Fix failed - QA environment.

Automation for Jira 30 August 2023, 11:18

Hello @Miłosz Jaskólski ]

This is the best moment to add more information that can be helpful for tester.

  • What areas are affected?

  • What are potential edge cases?

  • Was it checked for XSS problems?

  • Does change affect security, is new data exposed?

Please attach - Before / After screenshot if possible.

Aleksandra Bogdan 30 August 2023, 09:56

@Miłosz Jaskólski Looks great!

Automation for Jira 29 August 2023, 17:24

Hello @Aleksandra Bogdan,
Task is ready for review.

@Miłosz Jaskólski please make sure reviewer
have easy access to contend to be reviewed.

If this is code change. Please make sure PR is created.
If this is new documentation, blogpost, etc. Please provide link to page.

Miłosz Jaskólski 29 August 2023, 17:23

Dark mode version works now, also made light version of the pop out more similar to already existing style of the app