Carol is not updating the short URL auth param
Description
Person of contact
- @Bruno Furtado
Problem
I'm trying to enable in a tenant using a Org Admin token but Carol is returning success=false
.
curl -X 'PUT' \
'https://totvsclockin.carol.ai/api/v3/admin/tenants/b2100c6123bf4691a3bd9b9c1d5f8a6f' \
-H 'accept: application/json' \
-H 'Content-Type: application/json' \
-H 'Authorization: Bearer TOKEN' \
-d '{ "mdmCdsShortURLAuthentication": true }'
{
"success": false
}
Steps to reproduce
Just try to send a PUT request using an Org Admin or Carol Admin token (as shown above).
The behavior is indeed reproducible:
GCP: https://cloudlogging.app.goo.gl/xXdn6VJhXGjFut3C7
- CAROL ADMIN ATTEMPT
Links
Expected behavior
- As a Org Admin or Carol Admin I should be able to change the short url auth param from false to true.
Activity
Show:
This issue was automatically transitioned to DONE after being deployed to production on Github.
https://github.com/totvslabs/mdm/releases/tag/v4.89.4
No associated issue on JIRA TOTVS BRAZIL.
This issue was automatically transitioned to WAITING DEPLOY, as its PR was just merged into master branch in Github.
Github user douglascoimbra has just approved a PR (added as Shard Assignee in this Jira issue).
fix: https://totvslabs.atlassian.net/browse/CAPL-5112#icft=CAPL-5112 shortURL public access error
This issue was automatically transitioned to QA REVIEW, as its PR was just approved in Github.
FIXED FOR TENANT ADMIN, GLOBAL ADMIN + GLOBAL ADMIN OVERRIDDEN TENANT ID
@Bruno Furtado @Gabriel DAmore Marciano Based on an existing business rule, OrgAdmin cannot update the mdmCdsShortUrl parameter. We can revisit it in a new card to the product team.
Feel free to contact us for more details
cc @Robson Thanael Poffo @Lucas Noetzold
@Lucas Noetzold TEST FAILED
As Org Admin we are still receiving success: false in the response
2. If we pass the parameter as false with any kind of. token, an error occurs
1
2
3
4
5
6
This issue was automatically transitioned to REVIEW, as its PR (not DRAFT and not WIP) was just created in Github.
fix: https://totvslabs.atlassian.net/browse/CAPL-5112#icft=CAPL-5112 shortURL public access error
@MARCOS STUMPF ,
@Geny Isam Hamud Herrera ,
This issue was planned to be delivered until 2023-12-11. You can check that by consulting the issue in the Due Date field.
Dates already planned for this issue: 2023-12-11
If External Issue Link field is filled, customer was also informed on JIRA TOTVS.
Message thread link on #red-phone channel:
https://totvscarol.slack.com/archives/C03NT4US9J9/p1701372915783449