Issue Type Icon CAPL-5112

Carol is not updating the short URL auth param

Description

Person of contact

  • @Bruno Furtado

Problem

I'm trying to enable in a tenant using a Org Admin token but Carol is returning success=false.

curl -X 'PUT' \
  'https://totvsclockin.carol.ai/api/v3/admin/tenants/b2100c6123bf4691a3bd9b9c1d5f8a6f' \
  -H 'accept: application/json' \
  -H 'Content-Type: application/json' \
  -H 'Authorization: Bearer TOKEN' \
  -d '{ "mdmCdsShortURLAuthentication": true }'

{
  "success": false
}

Steps to reproduce

Just try to send a PUT request using an Org Admin or Carol Admin token (as shown above).

The behavior is indeed reproducible:

GCP: https://cloudlogging.app.goo.gl/xXdn6VJhXGjFut3C7

  • CAROL ADMIN ATTEMPT

Links

Expected behavior

  • As a Org Admin or Carol Admin I should be able to change the short url auth param from false to true.

Attachments

image-20231201-...
119.9 KiB
image-20231201-...
113.7 KiB
image-20231201-...
100.8 KiB
image-20231130-...
100.8 KiB
image-20231130-...
139.8 KiB
Captura de Tela...
138.2 KiB

Activity

Show:
Automation for Jira 1 December 2023, 18:16 • Jira Internal Users

This issue was automatically transitioned to DONE after being deployed to production on Github.

https://github.com/totvslabs/mdm/releases/tag/v4.89.4

Automation for Jira 1 December 2023, 18:16 • Jira Internal Users

No associated issue on JIRA TOTVS BRAZIL.

Automation for Jira 1 December 2023, 17:18 • Jira Internal Users

This issue was automatically transitioned to WAITING DEPLOY, as its PR was just merged into master branch in Github.

Automation for Jira 1 December 2023, 17:18 • Jira Internal Users

Github user douglascoimbra has just approved a PR (added as Shard Assignee in this Jira issue).

fix: shortURL public access error

Automation for Jira 1 December 2023, 16:35 • Jira Internal Users

This issue was automatically transitioned to QA REVIEW, as its PR was just approved in Github.

Douglas Coimbra Lopes 1 December 2023, 15:40 • Jira Internal Users

FIXED FOR TENANT ADMIN, GLOBAL ADMIN + GLOBAL ADMIN OVERRIDDEN TENANT ID

  • @Bruno Furtado @Gabriel DAmore Marciano Based on an existing business rule, OrgAdmin cannot update the mdmCdsShortUrl parameter. We can revisit it in a new card to the product team.

  • Feel free to contact us for more details

  • cc @Robson Thanael Poffo @Lucas Noetzold

Douglas Coimbra Lopes 1 December 2023, 13:16 • Jira Internal Users

@Lucas Noetzold TEST FAILED

  • As Org Admin we are still receiving success: false in the response

2. If we pass the parameter as false with any kind of. token, an error occurs

1

2

3

4

5

6

{
  "applicationErrorCode": null,
  "errorCode": 409,
  "errorMessage": "Changing mdmCdsShortURLAuthentication to false is not supported",
  "possibleResponsibleField": null
}
Automation for Jira 1 December 2023, 01:10 • Jira Internal Users

This issue was automatically transitioned to REVIEW, as its PR (not DRAFT and not WIP) was just created in Github.

fix: shortURL public access error

Automation for Jira 30 November 2023, 20:35 • Jira Internal Users

@MARCOS STUMPF ,

@Geny Isam Hamud Herrera ,
This issue was planned to be delivered until 2023-12-11. You can check that by consulting the issue in the Due Date field.

Dates already planned for this issue: 2023-12-11

If External Issue Link field is filled, customer was also informed on JIRA TOTVS.

Automation for Jira 30 November 2023, 20:35 • Jira Internal Users

Message thread link on #red-phone channel:

https://totvscarol.slack.com/archives/C03NT4US9J9/p1701372915783449

Done

Details

Priority

Priority: HighestHighest

Assignee

Lucas Noetzold

Reporter

MARCOS STUMPF

Labels

RED_PHONE

Due Date

21 December 2023

Fix versions

CAPL_3.96

Components

DATA_INGESTION | SHORT_URL

Created

30 November 2023, 16:34

Updated

12 December 2023, 19:15

More fields

Created: 30 November 2023, 20:34 Updated: 12 December 2023, 23:15