Internal comments added on External cannot be deleted on Shared Page
Description
Internal comments added on External cannot be deleted on Shared Page.
Observation:
- Delete pop-up can be canceled
- Internal comment disappear on reloading the page
- Add Internal comment button appears bright when Reply to customer is also enabled
- Internal comments can be deleted correctly when Add/View public comments is enabled
Steps to Reproduce:
- Create a share on any JSM project
- Enable the "Add internal comments" option.
- Navigate to Comments > Add content > Click on Add Internal comment button
- Delete comment
- Observe Comment cannot be deleted
Expected result
Comment should be deleted or Page should refresh on adding internal comment on shared page.
Actual result
Internal comments added on External cannot be deleted on Shared Page.
Activity
Show:
Hello @Michał Błaszczykowski,
Please merge code to dev branch.
This is the best moment to add more information that can be helpful to prepare release notes.
Can you prepare short overview of change that can be used in release notes?
Please provide short GIF that showcase feature.
If GIF make no sense, can you provide image that highlights feature that can be used in release notes (cropped & annotated)?
@Michał Błaszczykowski Fix verified - QA environment.
Hello @Michał Błaszczykowski ]
This is the best moment to add more information that can be helpful for tester.
What areas are affected?
What are potential edge cases?
Was it checked for XSS problems?
Does change affect security, is new data exposed?
Please attach - Before / After screenshot if possible.
Hello @Michał Błaszczykowski,
Change was reviewed and approved.
Task is ready to be deployed to QA.
Once it is deployed to QA please move ticket to "To Test"
Thank you!
Hello @Krzysztof Bogdan,
Task is ready for review.
@Michał Błaszczykowski please make sure reviewer
have easy access to contend to be reviewed.
If this is code change. Please make sure PR is created.
If this is new documentation, blogpost, etc. Please provide link to page.
Hello @Krzysztof Bogdan
This is the best moment to add more description, wire-frames, comments.
Why we doing this?
What is expected result?