Fix issue checklist
Description
After recent changes in Issue Checklist, there are lots of problems with displaying it on shared issues that must be adressed.
[00000000675c37c5] 2024-10-21T17:42:49.974+02:00 ERROR 454905 --- [XNIO-1 task-27] o.a.j.s.s.e.i.i.IssueChecklistConverter : Error while parsing checklist item:
java.lang.StringIndexOutOfBoundsException: Index 4 out of bounds for length 0
at java.base/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55)
at java.base/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52)
at java.base/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213)
at java.base/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210)
at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98)
at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:106)
at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:302)
at java.base/java.lang.String.checkIndex(String.java:4828)
at java.base/java.lang.StringLatin1.charAt(StringLatin1.java:46)
at java.base/java.lang.String.charAt(String.java:1555)
at ovh.atlasinc.jira.share.share.external.integration.issuechecklist.IssueChecklistConverter.toIssueChecklistItem(IssueChecklistConverter.java:84)
at ovh.atlasinc.jira.share.share.external.integration.issuechecklist.IssueChecklistConverter.addLine(IssueChecklistConverter.java:66)
at ovh.atlasinc.jira.share.share.external.integration.issuechecklist.IssueChecklistConverter.createIssueChecklist(IssueChecklistConverter.java:47)
at ovh.atlasinc.jira.share.share.external.IssueView.getIssueChecklistModel(IssueView.java:1180)
at ovh.atlasinc.jira.share.share.external.IssueView.get(IssueView.java:431)
at ovh.atlasinc.jira.share.share.external.SharePageController.issueView(SharePageController.java:512)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)Linked issues
is duplicated by
ESFJ-1262
Fix issue checklist not updating status checkbox and progress bar for completed items
ESFJ-1262
Fix issue checklist not updating status checkbox and progress bar for completed items
Withdrawn
Activity
Show:
Details
Priority
MediumAssignee
Mariusz Szymański
Reporter
Krzysztof Bogdan
Labels
roadmap
Fix versions
Roadmap
Created
21 October 2024, 18:11
Updated
18 November 2024, 14:46
More fields
Created: 21 October 2024, 16:11
Updated:
18 November 2024, 13:46
Hello @Mariusz Szymański,
Please merge code to dev branch.
This is the best moment to add more information that can be helpful to prepare release notes.
Can you prepare short overview of change that can be used in release notes?
Please provide short GIF that showcase feature.
If GIF make no sense, can you provide image that highlights feature that can be used in release notes (cropped & annotated)?
Fix verified - QA env
@Polina Naumenko Okay, I think I've found the cause. I initially thought it was an issue with the PRO version, but it turned out that the headers were handled improperly. It should be fine now.
Fix failed - QA env
@Polina Naumenko There was a conflict with changes introduced by @Krzysztof Bogdan regarding handling custom field ids. It should be fixed now.
After changes, issue checklist should be once again supported by our shares, with new feature displaying checklist item status.
Hello @Mariusz Szymański
This is the best moment to add more information that can be helpful for tester.
What areas are affected?
What are potential edge cases?
Was it checked for XSS problems?
Does change affect security, is new data exposed?
Please attach - Before / After screenshot if possible.
Hello @Mariusz Szymański,
Change was reviewed and approved.
Task is ready to be deployed to QA.
Once it is deployed to QA please move ticket to "To Test"
Thank you!
@Krzysztof Bogdan @Parsa Shiva Recent changes made our code incompatible with Issue Checklist. This PR addresses that: https://bitbucket.org/warsawdynamics/atlassian/pull-requests/1851
Hello [~accountid:],
Task is ready for review.
@Mariusz Szymański please make sure reviewer
have easy access to contend to be reviewed.
If this is code change. Please make sure PR is created.
If this is new documentation, blogpost, etc. Please provide link to page.
Maybe releated with https://warsaw-dynamics.atlassian.net/browse/ESFJ-1263
@Mariusz Szymański Please, can you take a look?