When "Allow description edition" privilege is enabled then user is unable to click on links on the description as it will trigger the edit mode instead
Description
When the "Allow Description Edition" privilege is enabled on a user account, clicking on links within the description triggers the edit mode instead of directing the user to the linked page. Preventing users from accessing links within the description.
Steps to reproduce
- On any issue create a share with enabled "Allow description edition" privilege
- On the issue description add some links
- Open the share as external user
- Attempt to open the link from description
Actual result
Clicking on any link within the description field triggers the edit mode instead of directing the external user to the linked page.
Expected result
The link should open the relevant page or resource in a new tab or window, allowing the external user to access the linked content without triggering the edit mode.
Activity
Show:
Hello @Miłosz Jaskólski,
Please merge code to dev branch.
This is the best moment to add more information that can be helpful to prepare release notes.
Can you prepare short overview of change that can be used in release notes?
Please provide short GIF that showcase feature.
If GIF make no sense, can you provide image that highlights feature that can be used in release notes (cropped & annotated)?
@Miłosz Jaskólski Fix verified - QA environment.
@Michał
Hello!
The issue is partially fixed - There is a minor case that is not covered here. Smart links still open the edit mode when clicked instead of opening the link. This is especially problematic since the edit mode does not allow the user to open smart links, unlike with normal links. This effectively means that smart links cannot be accessed.
Hello @Miłosz Jaskólski ]
This is the best moment to add more information that can be helpful for tester.
What areas are affected?
What are potential edge cases?
Was it checked for XSS problems?
Does change affect security, is new data exposed?
Please attach - Before / After screenshot if possible.
Hello @Mariusz Szymański,
Task is ready for review.
@Miłosz Jaskólski please make sure reviewer
have easy access to contend to be reviewed.
If this is code change. Please make sure PR is created.
If this is new documentation, blogpost, etc. Please provide link to page.
Hello @Krzysztof Bogdan
This is the best moment to add more description, wire-frames, comments.
Why we doing this?
What is expected result?
@Krzysztof Bogdan Clicking the link does actually both things - it enters edition, and also follows the link (this way when you click back in browser, you are in edit mode). So it is not impossible to follow the link. Having said that, it is of course not a desirable behavior. Possible solutions:
* modify event listener to check if the original event was bubbled from a link click, if yes, ignore it (preferable solution, if I am correct that it is easy to identify the source of the event)
* modify page generation, to add “event.stopPropagation” on every link inside the description
Apart from that, there should be one more thing done in a scope of this task:
* modify event listeners for entering edit mode for both summary and description to check which mouse button was clicked, and enter edition mode only if it was left button.
@Michał Can you take a look