Clear database of common email hosting domains
Description
Execute a database cleanup to remove all instances of common email domains (e.g., 'gmail.com') from the shared domain records.
Linked issues
relates to
ESFJ-1129
Improve/unify the way common email domains are fetched for validation in a front-end
Gathering Interest
Activity
Show:
Additionally, ran a DB clean-up from common domains and seems that everything went OK
Hello @Mi艂osz Jask贸lski,
Please merge code to dev branch.
This is the best moment to add more information that can be helpful to prepare release notes.
Can you prepare short overview of change that can be used in release notes?
Please provide short GIF that showcase feature.
If GIF make no sense, can you provide image that highlights feature that can be used in release notes (cropped & annotated)?
Fix verified - QA env
Hello @Mi艂osz Jask贸lski
This is the best moment to add more information that can be helpful for tester.
What areas are affected?
What are potential edge cases?
Was it checked for XSS problems?
Does change affect security, is new data exposed?
Please attach - Before / After screenshot if possible.
Hello @Mi艂osz Jask贸lski,
Change was reviewed and approved.
Task is ready to be deployed to QA.
Once it is deployed to QA please move ticket to "To Test"
Thank you!
@Krzysztof Bogdan
@Mi艂osz Jask贸lski
@Krzysztof Bogdan
@Mi艂osz Jask贸lski Changes requested
on current share form warning looks pretty much the same
Hello @Krzysztof Bogdan,
Task is ready for review.
@Mi艂osz Jask贸lski please make sure reviewer
have easy access to contend to be reviewed.
If this is code change. Please make sure PR is created.
If this is new documentation, blogpost, etc. Please provide link to page.
@Krzysztof Bogdan
@Mariusz Szyma艅ski A warning that domain will be ignored
@Krzysztof Bogdan Sure. Would you mind providing any details how should it be reflected?
@Mariusz Szyma艅ski FYI - this needs to be reflected on new UI
@Mi艂osz Jask贸lski On backend we should remove those domains on create/update of share - so it will not be visible for logged in users. We have gmail users login and they see shares that are shared with gmail domain - we should prevent this.
User can allow to add those domains but we should display on UI that domain X/Y or Z is ignored (it will not stop share save)
@Mi艂osz Jask贸lski
https://gist.github.com/Evavic44/8348e357935d09f79d4c1616b0c20408