Clear database of common email hosting domains

Description

Execute a database cleanup to remove all instances of common email domains (e.g., 'gmail.com') from the shared domain records.

Linked issues

relates to
Issue Type Icon ESFJ-1129 Improve/unify the way common email domains are fetched for validation in a front-end Priority: Lowest
Gathering Interest

Activity

Mi艂osz Jask贸lski 24 July 2024, 11:48

Additionally, ran a DB clean-up from common domains and seems that everything went OK

image-20240724-114656.png
image-20240724-114703.png
Automation for Jira 24 July 2024, 11:41

Hello @Mi艂osz Jask贸lski,

Please merge code to dev branch.
This is the best moment to add more information that can be helpful to prepare release notes.

  • Can you prepare short overview of change that can be used in release notes?

  • Please provide short GIF that showcase feature.

  • If GIF make no sense, can you provide image that highlights feature that can be used in release notes (cropped & annotated)?

Polina Naumenko 24 July 2024, 11:41

Fix verified - QA env

Automation for Jira 23 July 2024, 18:26

Hello @Mi艂osz Jask贸lski

This is the best moment to add more information that can be helpful for tester.

  • What areas are affected?

  • What are potential edge cases?

  • Was it checked for XSS problems?

  • Does change affect security, is new data exposed?

Please attach - Before / After screenshot if possible.

Automation for Jira 22 July 2024, 17:15

Hello @Mi艂osz Jask贸lski,
Change was reviewed and approved.
Task is ready to be deployed to QA.
Once it is deployed to QA please move ticket to "To Test"

Thank you!

Mi艂osz Jask贸lski 22 July 2024, 09:09

@Krzysztof Bogdan

Krzysztof Bogdan 22 July 2024, 07:26

@Mi艂osz Jask贸lski

Mi艂osz Jask贸lski 19 July 2024, 14:17

@Krzysztof Bogdan

Krzysztof Bogdan 18 July 2024, 07:35

@Mi艂osz Jask贸lski Changes requested

Mi艂osz Jask贸lski 17 July 2024, 19:03

on current share form warning looks pretty much the same

image-20240717-190312.png
Automation for Jira 17 July 2024, 19:00

Hello @Krzysztof Bogdan,
Task is ready for review.

@Mi艂osz Jask贸lski please make sure reviewer
have easy access to contend to be reviewed.

If this is code change. Please make sure PR is created.
If this is new documentation, blogpost, etc. Please provide link to page.

Mariusz Szyma艅ski 16 July 2024, 11:39

@Krzysztof Bogdan

image-20240716-113854.png
Krzysztof Bogdan 16 July 2024, 09:22

@Mariusz Szyma艅ski A warning that domain will be ignored

Mariusz Szyma艅ski 16 July 2024, 09:21

@Krzysztof Bogdan Sure. Would you mind providing any details how should it be reflected?

Krzysztof Bogdan 15 July 2024, 13:00

@Mariusz Szyma艅ski FYI - this needs to be reflected on new UI

Krzysztof Bogdan 15 July 2024, 13:00

@Mi艂osz Jask贸lski On backend we should remove those domains on create/update of share - so it will not be visible for logged in users. We have gmail users login and they see shares that are shared with gmail domain - we should prevent this.

Krzysztof Bogdan 15 July 2024, 12:58

User can allow to add those domains but we should display on UI that domain X/Y or Z is ignored (it will not stop share save)

Krzysztof Bogdan 15 July 2024, 12:58