Exclude part of description from sharing

Description

If Allow edit is enabled → edit mode will contain hidden parts.

We need to document this limitation

Possibility to remove part of description from sharing.

Everything between <Hide start> and <Hide end> should not be shared.

This should not be removed from sharing

If there is no <Hide end> match → we should hide everything after in current scope.

So if <Hide start> is in table cell → we should hide everything after in cell but not outside cell.

Attachments

ESFJ-366 - No e...
306.1 KiB
ESFJ-366 - Hide...
967.6 KiB

Linked issues

relates to
Issue Type Icon ESFC-262 Exclude part of page from sharing Priority: Medium
Released
Issue Type Icon ESFJ-383 Edit mode removes inline code formatting on save button click Priority: Medium
Released

Activity

Parsa Shiva 26 April 2023, 23:20

@Krzysztof Bogdan Sorry forgot to ask for draft review - updated today, please review.

https://warsawdynamics-qa.atlassian.net/wiki/spaces/QA/pages/334561310/Exclude+content+macro+-+Jira Additionally I think we can update the existing exclude macro for Confluence to be consistent with the newly made Jira one so I prepared this, if you could please also review draft https://warsawdynamics-qa.atlassian.net/wiki/spaces/QA/pages/326893569/Exclude+content+macro+-+Confluence.

The blog post for this feature is already reviewed and approved so it will be first to push once this documentation is pushed to production.

Parsa Shiva 11 April 2023, 10:56

@Krzysztof Bogdan Improvement implemented - QA environment.

Krzysztof Bogdan 2 April 2023, 08:11

@Parsa Shiva Also I removed hidden part from change log (history tab) on shared page.

Krzysztof Bogdan 2 April 2023, 07:46

@Parsa Shiva I have released new version which hides content from email.

It works different as in normal web page.
Due to reason what description is markdown (not html) - there is no easy way to define scope.

So in email there are no scopes. For example:

Table in description creates scope
But not in email
This cell should be visible (on shared page)
but will be hidden in email because hide start is treated differently

That mean - we might remove extra content that is available in shared page.

People might get notification that content has changed but changed part is hidden
That mean change was in hidden part.

Parsa Shiva 30 March 2023, 17:25

@Krzysztof Bogdan yes I recall, please ping me here when that will be done. Or we can have subtask for it.

Krzysztof Bogdan 30 March 2023, 17:22

@Parsa Shiva One more thing. I have to remove part of data from notification email

Krzysztof Bogdan 30 March 2023, 15:39

We can think of better handling this later but for now it should be enough

Krzysztof Bogdan 30 March 2023, 15:38

@Parsa Shiva That works as expected.

Please test this in Jira editor.
There is difference between:
1. <hide start> <ctrl-enter> …text…
and
2. <hide start> <enter> …text…

In first case hide macro and text below are in same, nested scope.
In second case, macro and text are in different scopes.

Parsa Shiva 28 March 2023, 15:15

@Krzysztof Bogdan

Now <Hide Start> will disappear but does not exclude any content and <Hide end> is displayed as part of content as well.

Unable to render embedded object: File ( ESFJ-366 Released - No exclusion.mp4) not found.

Krzysztof Bogdan 24 March 2023, 17:37

@Parsa Shiva Ready to test

Krzysztof Bogdan 24 March 2023, 16:57

@Parsa Shiva Once I will deploy update to QA

Parsa Shiva 24 March 2023, 16:40

@Krzysztof Bogdan So should I put it back to progress?

Krzysztof Bogdan 24 March 2023, 16:36

@Parsa Shiva on other hand I have one more idea how to hack this

Krzysztof Bogdan 24 March 2023, 16:20

@Parsa Shiva We accept this as limitation of what we can do

Parsa Shiva 24 March 2023, 16:10

@Krzysztof Bogdan Do we follow up on this before launch or accept it as production defect?

Krzysztof Bogdan 24 March 2023, 16:04

@Parsa Shiva
Unfortunately this is another error from Jira side.

Parsa Shiva 22 March 2023, 14:37

@Krzysztof Bogdan
Issue persists - QA environment.

<Hide end> does not work.

Unable to render embedded object: File ( ESFJ-366 Released - Hide stop.mp4) not found.

Krzysztof Bogdan 20 March 2023, 13:40

@Parsa Shiva Please re-test.
I have updated macro in a way that now macro is case insensitive.

Krzysztof Bogdan 17 March 2023, 15:29

@Parsa Shiva Can you show example how to reproduce problem?

Parsa Shiva 17 March 2023, 15:22

@Krzysztof Bogdan

Some issues occur, such as the <Hide end> not stopping the exclusion but it’s hard to provide accurate result without fixing.

Krzysztof Bogdan 8 March 2023, 17:17

Affected areas:
Issue description,

Custom field with rich text,
Filter share with Description column, rich text custom field.

Krzysztof Bogdan 8 March 2023, 13:29

@Parsa Shiva Ready to test

Krzysztof Bogdan 7 March 2023, 18:45

@Mariusz Szymański
Please take a look at PR: https://bitbucket.org/warsawdynamics/atlassian/pull-requests/224