Approver is not informed an approval is in a space they have no access to
Description
If an approval is located in a space to which the approver has no access, they will not be sufficiently informed about that fact:
-
The approval is listed in the Approvals List and the My Approval Queue, but clicking the ticket hyperlink opens the main Jira page without any message to user they cannot access the space:
-
If a ticket was originally created in a space the approver has access to but was then moved to a space they cannot access, the ticket will still be listed under the old ticket key in the Work Item column in the Approvals List and the My Approval Queue:
Change
-
Approvals list and My approval queue (and the approvals table in the dashboard gadget): when the user's work item lookup does not return a work item (it is in a space they don't have access to, or it was deleted), the Work item and Work item key cells show the key and summary as plain text instead of a link; the tooltip shows the full key and summary and below it "You can't open this work item. It is in a space you don't have access to, or it was deleted."
-
In such rows Open approval and the quick decision buttons (Approve, Reject, Abstain) are disabled and show the same text. View approval details and the other row actions are unchanged.
-
No extra Atlassian calls: the list already looks up the work items as the user and now keeps the ones that came back missing.
-
Built on AP-2182: work item links open /browse/<KEY>.
-
Confluence lists are unchanged.
Decisions
-
Work items moved before the key refresh on move (AP-2374) keep their old key in the lists; no backfill. Moves since then update the key.
-
A work item Jira doesn't return to the user for any other reason (for example archived work items on Premium sites, if Jira leaves them out) is shown the same way.
Fixes included
-
Web API: after a work item is moved, approvals return its new key right away instead of the old key for up to 24 hours.
Manual tester notes
-
Start an approval on a work item in a space the approver can't browse (the approver is added by user, not by project role). As that approver open the Approvals list: the Work item cell shows the key and summary as plain text, hovering it shows the full key and summary and "You can't open this work item. It is in a space you don't have access to, or it was deleted."
-
In that row, hover the row actions: Open approval and Approve/Reject are greyed out with the same text. View approval details still works.
-
My approval queue: same checks.
-
A work item the approver can browse: the link and all row actions work as before.
-
Move a work item with an ongoing approval to another space, then reload the Approvals list: the Work item column shows the new key, also for an approver without access to the new space.