A decision on a blocked group step is missing from the Notify step's decisions list and from Rovo's decision history
Description
Depends on: AP-2495 (blocked group steps) and AP-2423 (Notify step, decisions template variable), both in dev.
Problem
-
When a group step is blocked (AP-2495), the approval starter or a global admin decides it for the group, with a required comment. The decision is stored on the step itself (who decided, approved or rejected, date, comment), not as a vote of a group member.
-
The approval panel and approval details show it as the last entry of the step (decider, decision, date, comment), Activity shows "Decided for a blocked group by ..." with the comment, and the Slack decision message lists the decider and the comment.
-
The list of decisions behind the Notify step and Rovo (
DecisionFacts.decided) reads only the members' votes of a group step, so this decision is missing:-
the
decisionsvariable of the "Approval approved notification" and "Approval rejected notification" messages leaves it out. When the starter rejects a blocked step, the rejected message lists the members' votes (for example one approval and one rejection) but not the decision that rejected the approval, nor its comment; -
Rovo "Explain an approval" leaves it out of the decisions it lists, and Rovo approval search shows an earlier member vote as the approval's last decision.
-
Group steps exist in both products; the behaviour is the same in Jira and Confluence.
Change
-
DecisionFactsadds one decision for a group step decided for a blocked group: the decider as the approver, Approved or Rejected by the step's status, the step's decision date and its comment. It comes after the members' votes of that step, as in the panel. -
The Notify
decisionsvariable and Rovo (Explain an approval, the last decision in search) show it through that list. The limit of the last 100 decisions and the ordering by date stay. -
Group steps decided by votes are listed as today.
Acceptance criteria
-
A group step is blocked (group of 2, 2 to pass, 2 to fail, one member approves, one rejects); the starter rejects it with a comment and the approval is rejected: the rejected Notify message lists both votes and the starter's rejection, with its date and comment.
-
A global admin approves a blocked step with a comment and the approval is later approved: the approved Notify message lists the admin's approval, with its date and comment.
-
Rovo "Explain an approval" lists the blocked-step decision with the decider and the comment; Rovo approval search shows it as the last decision when it is the newest.
-
Approvals without a blocked-step decision list the same decisions as before.
Manual tester notes
-
Definition: a group step with a group of 2, 2 to pass and 2 to fail, followed by a user step. Add a Notify step to Success and to Rejection, with Approval creator as the recipient and the default templates.
-
Start an approval. One member approves, the other rejects: the step shows "Blocked: ...".
-
As the starter, reject the blocked step with a comment. Open the "Approval rejected" message: the decisions end with the starter's rejection, its date and comment, matching the panel and Activity.
-
Start another approval, make the step blocked again, approve it as a global admin with a comment, then approve the user step. The "Approval approved" message lists the admin's approval with the comment.
-
Ask Rovo to explain the first approval: its decisions include the starter's rejection with the comment. Ask Rovo to find recently rejected approvals: the last decision shown for it is the starter's rejection.
-
Repeat the first case in Confluence.